Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup, deprecate ContributionSoft::retrieve #23106

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

This removes the only call to ContributionSoft::retrieve that I could
find in core, hence I added a deprecation notice to the function.

There could be some extension uses - although it would never have
been supported to call this rather than the api

@civibot
Copy link

civibot bot commented Apr 6, 2022

(Standard links)

@civibot civibot bot added the master label Apr 6, 2022
@eileenmcnaughton eileenmcnaughton changed the title Test cleanup Test cleanup, deprecte ContributionSoft::retrieve Apr 6, 2022
@eileenmcnaughton eileenmcnaughton changed the title Test cleanup, deprecte ContributionSoft::retrieve Test cleanup, deprecate ContributionSoft::retrieve Apr 6, 2022
This removes the only call to ContributionSoft::retrieve that I could
find in core, hence I added a deprecation notice to the function.

There could be some extension uses - although it would never have
been supported to call this rather than the api
@eileenmcnaughton
Copy link
Contributor Author

thanks @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants