Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test usability fix #23096

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Test usability fix #23096

merged 1 commit into from
Apr 6, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Having the dummy data in the past causes debugging pain

@civibot civibot bot added the master label Apr 4, 2022
@civibot
Copy link

civibot bot commented Apr 4, 2022

(Standard links)

@eileenmcnaughton eileenmcnaughton force-pushed the ev_paid branch 2 times, most recently from 6c2b330 to ffd9ed2 Compare April 4, 2022 06:13
@seamuslee001
Copy link
Contributor

@eileenmcnaughton

not ok 3019 - Failure: CRM_Utils_TokenConsistencyTest::testEventTokenConsistency
  ---
  message: 'event.end_date :October 23rd, 2008 .  not found in  MIME-Version: 1.0'
  severity: fail
  ...

@eileenmcnaughton
Test usability fix
d037332 
Having the dummy data in the past causes debugging pain
@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 it passed

seamuslee001
seamuslee001 reviewed Apr 4, 2022
View reviewed changes
tests/phpunit/CiviTest/CiviUnitTestCase.php
@@ -1119,10 +1119,10 @@ public function eventCreate(array $params = []): array {
'event_type_id' => 1,
'is_public' => 1,
'start_date' => 20081021,
'end_date' => 20081023,
'end_date' => '+ 1 month',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so a 6 year event? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seamuslee001 yeah - key thing is the end date is in the future & start date is in the past so when you try to use it you don't get told it is invalid

@colemanw
Copy link
Member

colemanw commented Apr 6, 2022

Better than it was before anyway.

@colemanw colemanw merged commit 00cca05 into civicrm:master Apr 6, 2022
@colemanw colemanw deleted the ev_paid branch April 6, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seamuslee001 seamuslee001 seamuslee001 left review comments

Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eileenmcnaughton @seamuslee001 @colemanw