Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Create polyfill function for array_key_first which only exists … #23095

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

seamuslee001
Copy link
Contributor

…in php7.3 and onwards

Overview

As we still need to support PHP7.2 for the moment this is necessary to fix matrix test runs

Before

Tests fail on Master Matrix

After

Tests pass

ping @eileenmcnaughton @colemanw @MegaphoneJon

@civibot
Copy link

civibot bot commented Apr 3, 2022

(Standard links)

@civibot civibot bot added the master label Apr 3, 2022
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 is there a reason not to use the sympony polyfill via composer? I feel like it might prevent other similar issues...

@seamuslee001 seamuslee001 force-pushed the array_key_first_fix branch from cde3917 to a4cde1a Compare April 3, 2022 23:31
@seamuslee001
Copy link
Contributor Author

good point @eileenmcnaughton that should work too

@eileenmcnaughton eileenmcnaughton merged commit 9dc6209 into civicrm:master Apr 4, 2022
@eileenmcnaughton eileenmcnaughton deleted the array_key_first_fix branch April 4, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants