Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#3034 #23083

Merged
merged 1 commit into from
Apr 4, 2022
Merged

dev/core#3034 #23083

merged 1 commit into from
Apr 4, 2022

Conversation

jaapjansma
Copy link
Contributor

Overview

This is a follow up PR for #22532

Steps to reproduce

  1. Create a case
  2. Export document from this case
  3. Check the activity Print/Meger document

Before

When creating a document from the manage case screen. The attachment at the activity has the file name of .unknown.

After

When creating a document from the manage case screen. The attachment at the activity has the file name of CiviLetter.pdf.

Comments

I also checked the other formats such as ODT and HTML and Word. All of them ended up with a filename attached to the activity with the name .unknown.

@civibot
Copy link

civibot bot commented Apr 1, 2022

(Standard links)

@civibot civibot bot added the master label Apr 1, 2022
@demeritcowboy
Copy link
Contributor

With this applied I get a double extension when using non-pdf format, e.g. CiviLetter.docx.docx ?

@jaapjansma
Copy link
Contributor Author

@demeritcowboy yes you are right. I have solved that.

@demeritcowboy
Copy link
Contributor

Ok thanks @jaapjansma . I see this is only coming up when you have changed the setting at System Settings - Misc to "combined with file attachment", and so refers to the attachment that then gets stored on the activity, not the downloaded file.

Can you just squash commits?

Fix for issue 3034
@jaapjansma
Copy link
Contributor Author

I have squashed the commits into one.

@demeritcowboy demeritcowboy merged commit 5be4ec1 into civicrm:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants