🪲 🪳 Bug Fix: The option "Enable multiple bulk email address for a contact" does not apply when editing a Contact, only works for inline edit of email addresses #23082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tact" does not apply when editing a Contact, only works for inline edit of email addresses
|
(Standard links)
|
|
Test this please |
|
When reviewing this PR we discovered that the checkbox for bulk mail now works like a radio button. Only one e-mail address can be selected for bulk mail. See below a screen recording, which shows the contact edit and the inline edit.
Note: In our test environment the option for on hold is a checkbox, in your screenhots it is a drop down. |
|
@agileware-justin can you adjust your PR? Thanks anyway! |
|
To reproduce this bug, first enable the option, Enable multiple bulk email address for a contact.
Then perform the following tests:
|
|
I was able to replicate this bug & the fix. I'm pretty sure the reason I could replicate it & @jaapjansma / @BettyDolfing couldn't was that the explanation had become clearer in the mean time so I'm going to merge rather than ask for further input from @jaapjansma / @BettyDolfing Also I think the icons in the PR title helped.... |
|
that's scary |
|
Don't be afraid, it's just Harry Styles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The option "Enable multiple bulk email address for a contact" does not apply when editing a Contact, only works for inline edit of email addresses. Bulk Email checkbox forces singular selection.
To reproduce this bug, first enable the option, Enable multiple bulk email address for a contact.
Then perform the following tests:
Before
The option "Enable multiple bulk email address for a contact" does NOT work when editing a Contact.
After
The option "Enable multiple bulk email address for a contact" does work when editing a Contact.
Technical Details
Comments
Agileware Ref: CIVICRM-1958