Cleanup FinancialAccount BAO to use writeRecord
and deprecate add
#23079
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup the FinancialAccount BAO, consistent with other cleanups.
Technical Details
The thrust of this was to deprecate the
add
function in favor ofwriteRecord
, but in the process I found and fixed several problems:BAO::add
function instead of declared in the schema.is_active
was being set to0
. That's a bad default & we're trying to consistently set allis_active
fields todefault 1
across all entities.is_deductible
field default value. It was set todefault 1
in the schema, but that was overridden by the BAO for no apparent reason, which forced it todefault 0
. I've changed it to0
in the schema for consistency with the status-quo.CRM_Core_PseudoConstant::flush()
was being called after create/update but not after delete. I've fixed that via a post hook to handle all 3 operations.