dev/financial#186 Do not display partially paid & partially refunded for selection on edit #23076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for selection on edit I'm pretty sure these were actually removed at one point and got over-added back because the original fix over-removed them - ie it took them out when the contribution's current status was 'Partially paid' etc, making a no-save change impossible
|
(Standard links)
|
|
Agree with this change. Tested on local, works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/financial#186 Do not display partially paid & partially refunded for selection on edit
Before
When editing a pending contribution it is possible to select 'Partially paid' or 'Partially refunded' as the new contribution status - however, this was not intended as the way people would reach these statuses - the Add Payment/refund functionality should be used
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
I'm pretty sure these were actually removed at one point and got over-added
back because the original fix over-removed them - ie it took them out
when the contribution's current status was 'Partially paid' etc,
making a no-save change impossible
Comments