dev/financial#201 Do not add pledge statuses to Contribution statuses

[eileenmcnaughton]

Overview

Do not add pledge statuses to Contribution statuses on new installs

Historically Pledge statues, recurring contribution statuses and contribution statuses shared
one option group. When they were split out the pledge ones remained in the contribution status group.

This removes them from the contribution status group on install

Before

New installs of CiviCRM have contribution status 'Overdue' and 'In progress' - but there is no appropriate logic for them

After

The statuses are not adde don new installs

Technical Details

This doesn't touch existing installs. Options for existing installs

1. do nothing
2. add a status check & suggest people disable them if they exist and are not used (downside is this adds an ongoing performance cost to the status checks - esp on larger sites - although slow status checks can be disabled through the api)
3. add a one-off notice in the upgrade script if sites not are using these statuses but they are active
4. remove the statuses in an upgrade script if not in use
5. disable the statuses in an upgrade script if not in use

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Hmm

CRM_Core_Payment_PayPalIPNTest::testIPNPaymentRecurSuccess
Undefined array key "In Progress"

/home/jenkins/bknix-dfl/build/core-23074-5e1z/web/sites/all/modules/civicrm/CRM/Core/Payment/PayPalIPN.php:146
/home/jenkins/bknix-dfl/build/core-23074-5e1z/web/sites/all/modules/civicrm/CRM/Core/Payment/PayPalIPN.php:253
/home/jenkins/bknix-dfl/build/core-23074-5e1z/web/sites/all/modules/civicrm/tests/phpunit/CRM/Core/Payment/PayPalIPNTest.php:125
/home/jenkins/bknix-dfl/build/core-23074-5e1z/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:262
/home/jenkins/bknix-dfl/extern/phpunit8/phpunit8.phar:671

[eileenmcnaughton]

Ah - an instance of recur statuses being used for recurring -

if ($recur->contribution_status_id != $contributionStatuses['Completed']) {
  $recur->contribution_status_id = $contributionStatuses['In Progress'];
}

[eileenmcnaughton]

#23081 addresses the paypal bug

[eileenmcnaughton]

test this please

[pfigel]

ping @bjendres - this is probably relevant for CiviSEPA (which goes through Pending => In Progress => (Completed|Cancelled) IIRC).

[eileenmcnaughton]

@pfigel I think you might know of the ensureOptionValueExists function - it's not officially supported for use outside core but I doubt it is changing anytime soon & it is pretty handy

[bjendres]

ping @bjendres - this is probably relevant for CiviSEPA (which goes through Pending => In Progress => (Completed|Cancelled) IIRC).

Thanks, I've added Project60/org.project60.sepa#632

[eileenmcnaughton]

CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentExpressRecurSuccess
CRM_Pledge_BAO_PledgeTest.testAdd
CRM_Pledge_BAO_PledgeTest.testRetrieveKnownPledgeID
CRM_Pledge_Form_PledgeTest.testPostProcess
CRM_Report_Form_Member_DetailTest.testAutoRenewDisplay
api_v3_PledgePaymentTest.testProcessPledgeJob
api_v3_PledgeTest.testPledgeGetReturnFilters
api_v3_PledgeTest.testGetOverduePledge
api_v3_PledgeTest.testSortParamPledge
api_v3_PledgeTest.testCreatePledgeWeeklySchedule

[eileenmcnaughton]

checking test status now...

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

#24051

[eileenmcnaughton]

Test Result (3 failures / -11)
CRM_Core_Payment_PayPalProIPNTest.testIPNPaymentExpressRecurSuccess
CRM_Pledge_Form_PledgeTest.testPostProcess
CRM_Report_Form_Member_DetailTest.testAutoRenewDisplay

[eileenmcnaughton]

test this please

[eileenmcnaughton]

Test Result (2 failures / +2)
CRM_Pledge_Form_PledgeTest.testPostProcess
CRM_Report_Form_Member_DetailTest.testAutoRenewDisplay

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[seamuslee001]

Now that the RC is cut this seems fine to merge