(dev/core#3141) Membership should be listed chronologically by join d…

[yashodha]

…ate, the most recent member since first

Overview

All memberships (active and inactive memberships) should be listed chronologically by join date, the most recent member since first.
This is followed on Membership dashboard but not Member tab or Member Userdashboard. The behavior should be consistent.

Before

After

fixed chronologically by join date on Userdashoard for active/inactive members

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

@yashodha I agree with this change. How are the other items on the user dashboard (such as events, contributions) sorted. I expect they should also be sorted by newest first.

[yashodha]

@mattwire There is a regression for contribution userdashboard (refer : https://lab.civicrm.org/dev/core/-/issues/1763)
I will be submitting a separate PR for that as well. It would be great to get this merged independently. Thanks!

[BettyDolfing]

Test this please

[yashodha]

@eileenmcnaughton @mattwire Can you please merge? This is pretty straight forward. Thanks!

[jaapjansma]

@BettyDolfing and I did a review of this PR and we discovered the the order on the membership tab on the contact record is still not in chronological order. On the dashboard it is.

Wrong: Member tab on contact card

Correct: Memberlist on dashboard

@yashodha can you have another look into the member tab on the contact record? Thanks!

[yashodha]

@jaapjansma there are 3 screens to check for this behavior :

Member Dashboard
correct behavior

Member Userdashboard
this PR fixes the behavior as per Member Dashboard

Member tab
wrong behavior still. This will be fixed in upcoming PR's!

For reference, check https://lab.civicrm.org/dev/core/-/issues/3141
This PR can be merged as this is in sync with the correct behavior of Member Dashboard

[eileenmcnaughton]

Per @yashodha I'm ok with merging this - it is a super-simple patch that adds a sort-by.

The most important consistency is within the same page - which @yashodha has indicated she plans to address

However, I do wonder if we should sort be end_date or end_date,start_date rather than start_date?

[yashodha]

@eileenmcnaughton Good point. I only did start date because the Member Dashboard was following this.

Let me know the consensus on this one and I will make changes accordingly . Whatever we decide will have to make changes to all 3 screens to keep it consistent.
Thanks!

[eileenmcnaughton]

I've added a note to include this in the next dev-digest

[jaapjansma]

test this please

[jaapjansma]

@yashodha there is no feedback given on this issue since it has been mentioned in the dev-digest. As CiviCRM is open source it is basically scratch-your-own-itch so I believe you can decide which field the sorting should be on and make sure it is consistent on all three pages (eventually with separate PR but it could also be done in one PR). Could you do that? Thanks!

[eileenmcnaughton]

Opps looks like that digest hasn't actually gone out - will aim to get it out this weekend

[yashodha]

@eileenmcnaughton this is straight forward fix and definitely a step up from current state and in sync with what is already there on Member Dashboard. I think this could be merged and if there's a future consensus we can update all the screens.

[eileenmcnaughton]

OK - I accept that - the dev digest item has gone out now so people have had a chance to comment

[yashodha]

thanks!