Stop passing settings into getTaxLabel

[eileenmcnaughton]

Overview

Stop passing settings into getTaxLabel

Before

CRM_Price_BAO_PriceField::getTaxLabel is called from 2 places in the code. In both places the values passed into the function as $displayOpt and $taxTerm are just the settings. In one place these are only retrieved to be passed into this function

public static function getTaxLabel($opt, $valueFieldName, $displayOpt, $taxTerm, $currency = NULL) {

After

Settings don't need to be passed around.... removed from the function signature

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Agreed, there's no reason to pass global settings into a function. It can look them up itself.