Keep "EntityFile" records available until after Symfony "delete" hooks fire

[christianwach]

Overview

Solves a small part of problems raised in this Lab issue.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[christianwach]

Genuinely no idea why checks have failed on this - all I did was move a block of code 🤷

[demeritcowboy]

The test fail makes sense to me. Attachments/files can be attached to more than one instance of an entity, e.g. the same file can be attached to two activities. So civi checks the reference count for attachments before removing from the filesystem. Because the reference isn't deleted until after that check now, it thinks there's still an entity instance using the file, so it won't delete the physical file.

[christianwach]

Ah dammit, thanks @demeritcowboy. Back to the drawing board.