REF Cleanup activity getBespokeTokens() #22974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This line is never used:
$tokens['case_id'] = ts('Activity Case ID');
Before
Extra line that is never used.
After
$tokens['case_id']
only defined once.Technical Details
Note I specified it like this instead of just doing return [..] because it makes it much easier to apply patches such as eg. mattwire@67eb506
Comments