Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix property declarations #22965

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Fix property declarations #22965

merged 1 commit into from
Mar 18, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Mar 17, 2022 •
edited
Loading

Overview

Fix property declarations

Before

private int $contributionPageId;

After

  private $contributionPageId;

Technical Details

I think this property hinting must work on some php versions & not others - recently added by @MegaphoneJon & fails locally for me

Comments

@civibot
Copy link

civibot bot commented Mar 17, 2022

(Standard links)

@civibot civibot bot added the master label Mar 17, 2022
@demeritcowboy demeritcowboy merged commit aee8882 into civicrm:master Mar 18, 2022
@demeritcowboy
Copy link
Contributor

7.4-only feature

@seamuslee001 seamuslee001 deleted the privat branch March 18, 2022 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @demeritcowboy