Afform - reset managed entities when deleting a dashlet

[colemanw]

Overview

Fixes dev/core#3122

Before

Deleting an afform does not delete the related dashlet

After

Now it does

Technical Details

It wasn't as simple as adding a cache clear in the revert function, because if multiple afforms were being reverted at once, that would be very slow clearing the cache each time. So I refactored the BasicBatchAction to allow the cache to be cleared after the whole batch is processed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Unit test revealed this variable was leaky. The purpose of this function is to rebuild this array, but it needs to be reset first due to the singleton pattern.

[colemanw]

@MegaphoneJon can you confirm this fixes your issue?

[MegaphoneJon]

This doesn't fix the issue, but for what seems like an unrelated-ish regression. Deleting the Search Kit search no longer deletes the associated Form Builder form.

[colemanw]

@MegaphoneJon not according to the unit tests.This is still passing:

civicrm-core/ext/search_kit/tests/phpunit/api/v4/SearchDisplay/SearchAfformTest.php

Lines 242 to 247 in 095e8ae

	SavedSearch::delete(FALSE)
	->addWhere('name', '=', 'TestSearchToDelete')
	->execute();
	$this->assertCount(0, Afform::get(FALSE)->addWhere('search_displays', 'CONTAINS', 'TestSearchToDelete.TestDisplayToDelete')->execute());
	$this->assertCount(0, Afform::get(FALSE)->addWhere('name', 'CONTAINS', 'TestAfformToDelete')->execute());

[colemanw]

@MegaphoneJon actually I just took a closer look and you're right. The unit test wasn't catching this problem with deleting an afform using a "default display": #22997

So if we merge that PR as well as this one, it should all be working well according to the tests.

[colemanw]

@MegaphoneJon now that #22997 is merged are you good with merging this one too?

[MegaphoneJon]

I have no objection to this being merged - but it also seems as though #22997 was the bug that was generating the error for end users.

When this PR is applied I can see that the entry in civicrm_dashboard is deleted immediately when the Search Kit search is deleted. However, when the patch isn't applied, the dashboard isn't broken - it simply doesn't show the dashlet, and when cache is cleared, the civicrm_dashboard record is removed.