Notice fixes in advanced search

[eileenmcnaughton]

Overview

Fix smarty notices

Before

Smarty notices in grumpy mode

After

Help still works

Technical Details

This assign is never actually used anywhere
{capture assign=helpFile}{if $fieldSpec.help}{$fieldSpec.help}{else}''{/if}{/capture}
I think it was a good intention - we can see by the surrounding lines that $help should be an array

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This assign is never actually used anywhere
{capture assign=helpFile}{if $fieldSpec.help}{$fieldSpec.help}{else}''{/if}{/capture}
I think it was a good intention - we can see by the surrounding lines that $help should be an array

(grin) Looks like this was originally partly copy/pasted from sketches in https://lab.civicrm.org/dev/core/-/issues/115