dev/core#3085 - Checkbox fields on profile admin page can't be unchecked

[spalmstr]

Overview

This is a third attempt at a PR for issue 3085 Checkbox fields on profile admin page can't be unchecked.

Before

Once a profile checkbox was checked it would not stay cleared.

After

Cleared checkboxes stay cleared.

Technical Details

Change 'checkbox' to 'advcheckbox' in ...civicrm-core/CRM/UF/Form/Group.php and AdvanceSetting.php. It is no longer necessary to check if $params['is_active'] exists, as advcheckbox makes sure it exists, even if cleared.

Comments

Thanks to @demeritcowboy for pointing out the advcheckbox fix.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

This works for me.

Aside: One thing I never noticed before but might be on purpose and also happens without the patch: If you uncheck is_active, then it removes any "Used For" checkboxes you had checked when it saves.