(dev/core#3106) Raise max# of editable websites (5 => 25) #22908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
LOL, thanks for the rhetorical Q&A :) |
|
This is fine IMO. It's going to make the Websites block slightly slower to load, but probably not very noticeable. |
|
No number is better than 25 (except for 12 - which has many nice ways to divide). But 25 is definitely good.
That white box is pre-existing and weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lab.civicrm.org/dev/core/-/issues/3106
Overview
The max number of websites available to inline edit is 5. Since "Websites" is also used to track folks' social media, it's pretty easy to exceed 5. I think we should change it to 25.
Before
After
Comments
You may be asking yourself, "Does anyone really need 25 websites per contact?" The answer is "Yes".