Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Improve checkbox UX for bulk actions #22906

Merged
merged 3 commits into from
Mar 14, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Mar 8, 2022

Overview

Improves selection of checkboxes for SearchKit bulk actions.

Before

  • No way to quickly select more than one row.
  • No way to de-select all without first selecting every row.

After

  • You can shift-click to quickly select multiple rows.
  • The "select all" checkbox shows a minus sign when some but not all records are selected, and clicking it will deselect them.
  • There is a dropdown next to the "select all" checkbox for finer control.
    image

Technical Details

This incidentally fixes a bug where the selection would leak into other search displays if there was more than one on the page, per #22887.

@civibot
Copy link

civibot bot commented Mar 8, 2022

(Standard links)

@civibot civibot bot added the master label Mar 8, 2022
@eileenmcnaughton
Copy link
Contributor

The styling is pretty funky under shoreditch (still testing)

image

@colemanw colemanw force-pushed the searchKitCheckBoxes branch from d776917 to 31a3970 Compare March 9, 2022 19:08
@colemanw
Copy link
Member Author

colemanw commented Mar 9, 2022

@eileenmcnaughton I updated the css for shoreditch. Now it looks like this:
image

@colemanw colemanw force-pushed the searchKitCheckBoxes branch from 31a3970 to 7ef2c5c Compare March 9, 2022 20:02
@eileenmcnaughton
Copy link
Contributor

I tested that I could select & export a page & that I could select & export all & it worked - it was out of order when using 'download spreadsheet' - which was odd but I didn't investigate as I think it doesn't relate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants