Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow template for offline event #22904

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Add workflow template for offline event

This locks in availability of participant and event tokens
along with the standard smarty variables of {contactID},
{participantID} and {eventID}

Before

Participant and Event ids & tokens not available to the template and hook (#22878 )

After

Tests ensure that participant & event ids work. Existing classes using the trait have tests in CRM_Event_Form_SelfSvcUpdateTest etc

Technical Details

This also removes the issets that cause failure with grumpy smarty mode

Comments

@civibot
Copy link

civibot bot commented Mar 8, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@demeritcowboy
Copy link
Contributor

demeritcowboy commented Mar 8, 2022

not ok 1746 - Error: CRM_Event_Form_ParticipantTest::testSubmitWithPayment with data set #0 ('.')
not ok 1747 - Error: CRM_Event_Form_ParticipantTest::testSubmitWithPayment with data set #1 (',')
not ok 1750 - Error: CRM_Event_Form_ParticipantTest::testParticipantOfflineReceipt with data set #0 ('.')
not ok 1751 - Error: CRM_Event_Form_ParticipantTest::testParticipantOfflineReceipt with data set #1 (',')
not ok 1795 - Error: CRM_Export_BAO_ExportTest::testAdditionalReturnProperties with data set #2 (6, array(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1))
not ok 1802 - Error: CRM_Export_BAO_ExportTest::testDefaultReturnProperties with data set #2 (6, array(1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1))
not ok 1809 - Error: CRM_Export_BAO_ExportTest::testGetSQLColumnsAndHeaders with data set #2 (6, array('`civicrm_primary_id` varchar(64)', '`contact_type` 
not ok 2133 - Error: CRM_Member_BAO_QueryTest::testConvertEntityFieldSingleValue
not ok 2134 - Error: CRM_Member_BAO_QueryTest::testConvertEntityFieldMultipleValueEntityRef
not ok 2135 - Error: CRM_Member_BAO_QueryTest::testConvertEntityFieldMultipleValueLegacy
not ok 2136 - Error: CRM_Member_BAO_QueryTest::testConvertEntityFieldMultipleValueEntityRefDoubleRun
not ok 2137 - Error: CRM_Member_BAO_QueryTest::testMembershipDateWhereSearchBuilder with data set #0 ('membership_join_date')
not ok 2138 - Error: CRM_Member_BAO_QueryTest::testMembershipDateWhereSearchBuilder with data set #1 ('membership_start_date')
not ok 2139 - Error: CRM_Member_BAO_QueryTest::testMembershipDateWhereSearchBuilder with data set #2 ('membership_end_date')
not ok 2310 - Error: CRM_Report_Utils_ReportTest::testOutputPrint
not ok 2333 - Error: CRM_Upgrade_Incremental_php_FiveTwentyTest::testChangeCaseTypeAutoassignee
not ok 2334 - Error: CRM_Upgrade_Incremental_php_FiveTwentyTest::testConvertRoleLabelsToNames
not ok 3008 - Error: CRM_Utils_TokenConsistencyTest::testCaseTokenConsistency

@eileenmcnaughton
Copy link
Contributor Author

Yeah something not good there!

@eileenmcnaughton eileenmcnaughton force-pushed the event_msg branch 6 times, most recently from c6425ca to 451757a Compare March 19, 2022 00:26
This locks in availability of participant and event tokens
along with the standard smarty variables of {contactID},
{participantID} and {eventID}
@eileenmcnaughton
Copy link
Contributor Author

This is finally passing - I made it a bit less ambitious

@colemanw
Copy link
Member

Code looks good & test coverage is solid.

@colemanw colemanw merged commit a5755b2 into civicrm:master Mar 22, 2022
@colemanw colemanw deleted the event_msg branch March 22, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants