-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow template for offline event #22904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
eileenmcnaughton
force-pushed
the
event_msg
branch
from
March 8, 2022 02:01
ddfd892
to
57a08d0
Compare
test this please |
|
Yeah something not good there! |
eileenmcnaughton
force-pushed
the
event_msg
branch
6 times, most recently
from
March 19, 2022 00:26
c6425ca
to
451757a
Compare
This locks in availability of participant and event tokens along with the standard smarty variables of {contactID}, {participantID} and {eventID}
eileenmcnaughton
force-pushed
the
event_msg
branch
from
March 19, 2022 02:20
451757a
to
c16c5e0
Compare
This is finally passing - I made it a bit less ambitious |
Code looks good & test coverage is solid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add workflow template for offline event
This locks in availability of participant and event tokens
along with the standard smarty variables of {contactID},
{participantID} and {eventID}
Before
Participant and Event ids & tokens not available to the template and hook (#22878 )
After
Tests ensure that participant & event ids work. Existing classes using the trait have tests in
CRM_Event_Form_SelfSvcUpdateTest
etcTechnical Details
This also removes the issets that cause failure with grumpy smarty mode
Comments