Cleanup variable assigns in ContributionPage confirm #22902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
commented
Mar 7, 2022
| if (!empty($result['payment_status_id'])) { | ||
| $contribution->payment_status_id = $result['payment_status_id']; | ||
| } | ||
| $form->assign('trxn_id', $result['trxn_id'] ?? ''); |
There was a problem hiding this comment.
Simpler to use NULL coalescing operator here.
mattwire
commented
Mar 7, 2022
| $contribution->payment_status_id = $result['payment_status_id']; | ||
| } | ||
| $form->assign('trxn_id', $result['trxn_id'] ?? ''); | ||
| $contribution->trxn_id = $result['trxn_id'] ?? $contribution->trxn_id ?? ''; |
There was a problem hiding this comment.
Rather than checking if return value from doPayment is empty we assign via a hierarchy which clearly shows priority
mattwire
commented
Mar 7, 2022
| } | ||
| $form->assign('trxn_id', $result['trxn_id'] ?? ''); | ||
| $contribution->trxn_id = $result['trxn_id'] ?? $contribution->trxn_id ?? ''; | ||
| $contribution->payment_status_id = $result['payment_status_id']; |
There was a problem hiding this comment.
Any payment processor that does not return payment_status_id is going to be broken in multiple ways because it is the only way to check if payment was successful..
|
Yep agree. Thanks @mattwire |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup and simplify some variable assigns.
Before
More complicated.
After
Less complicated.
Technical Details
See inline comments on this PR
Comments