Don't perform event timezone check if CiviEvent is disabled #22898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Utils/Check/Component/Event.php
Outdated
| * @inheritDoc | ||
| */ | ||
| public function isEnabled() { | ||
| CRM_Core_Component::isEnabled('CiviEvent'); |
There was a problem hiding this comment.
Makes sense - same as the CiviCase one. But needs a return statement though.
There was a problem hiding this comment.
@MegaphoneJon not sure if you saw my comment yesterday - this just needs a return in front and then is mergeable.
Suggested change
| CRM_Core_Component::isEnabled('CiviEvent'); | |
| return CRM_Core_Component::isEnabled('CiviEvent'); |
There was a problem hiding this comment.
Thanks, I missed it. Will fix tomorrow.
770a802 to
5389372
Compare
|
looks right to me MOP |
Merged
|
Have added backport to 5.47 at #22924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The new timezone check in 5.47 fails if you don't have CiviEvent enabled.
Before
API Exception: Event API is not available because CiviEvent component is disabled while checking events for timezones.in System Status.After
No error.
Comments
This error message was impressively accurate for being dynamically generated, well done APIv4.