Fix undeclared javascript variables #22879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These variables need to be declared with the `var` keyword, or it crashes some browsers.
|
(Standard links)
|
colemanw
commented
Mar 3, 2022
Comment on lines
+101
to
103
| var more = data.more_results; | ||
|
|
||
| if (more && !data.more_results) { |
There was a problem hiding this comment.
Maybe out-of-scope for this PR, but I just did a double take at the logic of these 2 lines. What the 💩???
😆
|
This seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes veda-consulting-company/uk.co.vedaconsulting.mosaico#494
Before
Javascript errors caused some functionality to break, notably the Mosaico Recipients widget.
After
All better.
Technical Details
These variables need to be declared with the
varkeyword, or it crashes some browsers.@MegaphoneJon noted that you have to disable debug mode to see the error manifest. It probably depends on your browser too. My theory about that is that in debug mode, each js file is served separately, and these files do not include the
"use strict";directive, but without debug mode the files all get cobbled together into one big js file, so if one of those said "use strict";` it would affect how the code in this file is treated.