php/smarty notices on contribution view part 2 #22869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
reviewed
Mar 2, 2022
| @@ -44,6 +44,16 @@ public function preProcess() { | |||
| $values = (array) $contribution; | |||
| $contributionStatus = CRM_Core_PseudoConstant::getName('CRM_Contribute_BAO_Contribution', 'contribution_status_id', $values['contribution_status_id']); | |||
|
|
|||
| if (!isset($this->get_template_vars()['hookDiscount'])) { | |||
| $this->assign('hookDiscount', ['message' => '']); | |||
There was a problem hiding this comment.
Yeah. Looking at it now maybe another way would be to just add hookDiscount in the expected smarty vars below, and then update the if in the template so it's {if $hookDiscount && $hookDiscount.message} instead of {if $hookDiscount.message}. I think I still have one more round before the other PR will pass so I will probably do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some variables not defined when viewing a contribution.
Before
Notice: Undefined index: pricesetFieldsCount in include() (line 124 of ...\templates_c\en_US\%%F2\F21\F21A46C1%%LineItem.tpl.php).Notice: Undefined index: hookDiscount in include() (line 150 of ...\templates_c\en_US\%%F2\F21\F21A46C1%%LineItem.tpl.php).... and more.
After
Still some more.
Technical Details
Comments
I've left currencySymbol in for now. I'm not a javascript expert but is this function even callable?
civicrm-core/templates/CRM/Price/Page/LineItem.tpl
Line 144 in 8f0f533