[REF] APIv4 - Use new class_args metadata to remove special handing #22853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…tomValue and CiviCase entities. Before: When creating an API request, special logic was needed for CustomValue and CiviCase apis. After: Metadata used.
0f55afc to
b27094b
Compare
|
Looks like a good change. I think the affected use-cases should already have pretty decent test-coverage. Merge on pass. |
|
Lol, right. Well, I've been working on a response to your observations over on that one. |
|
jenkins, test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleans up the internal process of resolving an APIv4 request, taking advantage of new metadata added in #22831 to remove workarounds and special cases.
Before
When creating an API request, special logic was needed for
CustomValueandCiviCaseapis.After
Metadata used.
Comments
This is massively covered by existing tests.