Avoid PHP undefined index notices on extension pages #22848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
On the extensions page (/civicrm/admin/extensions) various notices (undefined index) are thrown if the extension
info.xml
files are missing one or more keys. This adds a helper method to set relevant defaults for use in the twig files.This also removes use of
empty()
in thetemplates/CRM/Admin/Page/ExtensionDetails.tpl
template which is problematic with the newCIVICRM_SMARTY_DEFAULT_ESCAPE
.Before
Many PHP notices occur on the extension manager page:
After
The bulk of these notices are removed (a
Undefined index: tabHeader
still occurs, but this is a problem common to many other pages).