Remove reference to undefined variable in CRM_Contact_Form_Inline_CommunicationPreferences #22840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In #20214 a change was introduced which means the inline communication form references a missing variable. The biggest impact of that is that your PHP log is likely to end up with something like this:
The
if
statement could never be true, and setting a default on an edit form (as opposed to a create form) doesn't make much sense. Therefore I propose this block of code is removed.Before
PHP notice.
After
No PHP notice.