Enable APIv4 export action on UFGroup and UFField. #22832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@jmcclelland the style checker wants a blank line before the closing brace. |
a3276dc to
4249e44
Compare
|
Thanks! Ug - I need to remember to use |
|
Woops - @colemanw - Hm, now I'm not sure why this check failed. |
With these little changes the export action is available. It still needs a tweak because UFField exports `field_name` which hard codes a custom field's id instead of `field_name:name` - but I think it's a good first step.
4249e44 to
cad8453
Compare
|
@seamuslee001 thanks! I forgot to type |
|
This should be safe to merge now that we're early in the release cycle. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With these little changes the export action is available on the UFGroup and UFField Entities.
Before
The export action is not available in APIv4 on the UFField or UFGroup entities.
After
The export action is available.
Technical Details
None.
Comments
It still needs a tweak because UFField exports
field_namewhich hard codes a customfield's id instead of
field_name:name- but I think it's a good firststep.