dev/core#3077 - CiviCase - Call hooks when creating relationships

[colemanw]

Overview

Refactors creating relationships when opening a new case to use APIv4 (temporarily using the BAO method), which calls hooks.

Before

No hooks called.

After

Api used, hooks called, code easier to read.

Technical Details

The attempt to use APIv4 failed if the case client is an Organization, due to some extra (faulty?) validation & processing which happens at that layer. IMO that needs tests and fixing, but for now, this calls BAO_Relationship::add() directly.

Comments

I stepped through the unit tests and confirmed that this function has good test coverage.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

Looks fine to me @mattwire @demeritcowboy work for you?

[mattwire]

Works for me :-)

[demeritcowboy]

One of the exact same things happens as in the previous attempt to use api: It crashes for org clients. I haven't tested further because I now expect all the same issues will come up.

[colemanw]

@demeritcowboy do you remember what issue or PR that happened before?

[demeritcowboy]

I had linked to it in my comment on #22810 (comment) - it was #15030

[demeritcowboy]

In terms of whether it works or not this version works (note: the PR title/description is no longer accurate). I'll leave the r-tech discussion about add() to others - I would normally put merge-ready.

[colemanw]

Thanks for the r-run @demeritcowboy. I've updated the description & added the label.