Remove broken call to function_exists in CRM_Utils_String::isUtf8

[braders]

Overview

Fix call to function_exists in CRM_Utils_String::isUtf8

Before

In the line if (!function_exists(mb_detect_encoding)), mb_detect_encoding was being treated as a constant - mb_detect_encoding is not a constant, and function_exists expects a string.

After

Valid PHP code.

Comments

Given that this mistake has been unnoticed for a decade I did strongly suspect that the method isUtf8 should be deprecated, and in time removed - it seems unlikely that it is in widespread use.

However, the method is referenced from CRM_Utils_String::isAscii which is in use elsewhere in CiviCRM core. Given this, I was not sure if it was appropriate to deprecate isUtf8 whilst isAscii is still using it...

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I don't remember when but mb was made a system requirement for civi (https://docs.civicrm.org/installation/en/latest/general/requirements/#required-for-civicrm-core), so the function will always exist. I would just remove the if.

[braders]

I don't remember when but mb was made a system requirement for civi (https://docs.civicrm.org/installation/en/latest/general/requirements/#required-for-civicrm-core), so the function will always exist. I would just remove the if.

That sure does simplify things - changed!