Remove use of overrideDefaultCurrency method from eventInfo page. #22802
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the civicrm/event/info route to show the current currency in multi-currencies setups.
Before
As discussed in https://lab.civicrm.org/dev/core/-/issues/2930#note_66911,
CRM_Contribute_BAO_Contribution_Utils::overrideDefaultCurrency
does not work correctly with the new money functions recently introduced in 386fe6c and d6d93aa.Whilst there is a good argument for updating
CRM_Contribute_BAO_Contribution_Utils::overrideDefaultCurrency
to work with the new functions for backwards compatiability, I think moving away from overriding the default currency is a cleaner long-term solution.After
The
overrideDefaultCurrency
method is no longer used on the eventInfo page, and the correct currency is used, even if the event and default currencies are different.The getTaxLabel method has been updated to accept a new optional currency argument, in order to facilitate this change.
Comments
I've kept this PR minimal to start, and so have just focussed on this single eventInfo page - other pages can be handled through follow up PRs.