Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Use crmDialogButtons for task popups #22790

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

colemanw
Copy link
Member

Overview

Updates the buttons in SearchKit action popups to use standard dialog button formatting.

Before

Ad-hoc buttons inserted into the body of the dialog. This runs the risk that the buttons can scroll out of view.
image

After

Buttons fixed to the bottom of the dialog.
image

Technical Details

Uses new crmDialog and crmDialogButton directives.

@civibot
Copy link

civibot bot commented Feb 18, 2022

(Standard links)

@civibot civibot bot added the master label Feb 18, 2022
@monishdeb
Copy link
Member

Tested on my local, r-run passed.

@monishdeb monishdeb merged commit 889853d into civicrm:master Feb 21, 2022
@colemanw colemanw deleted the searchKitTaskButtons branch November 8, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants