Mailing - Add serialize and add to template_options field
#22785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
No need for special handling to json_encode the field, the BAO takes care of that automatically when `serialize` is declared. Test coverage in api_v3_MailingTest::testMailerCreateTemplateOptions
bb9cabc to
79216b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Improve the mailing schema metadata for
template_optionsandtemplate_typefields.Before
Field serialization missing from metadata, special handling added to api to compensate.
After
No need for special handling to
json_encodethe field, the BAO takes care of that automatically whenserializeis declared.Comments
Test coverage in
api_v3_MailingTest::testMailerCreateTemplateOptions