Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Fix support for non-DAO entities #22764

Merged
merged 1 commit into from
Feb 13, 2022

Conversation

colemanw
Copy link
Member

Overview

Fixes SearchKit to work with more entities.

Before

SearchKit would crash if running a search on a non-DAO entity (Extension, Entity, Afform, etc)

After

Works, test added

Technical Details

Had to remove assumptions about the entity params supporting join and having, a well as reliance on the Api4SelectQuery object.

Before: SearchKit would crash if running a search on a non-DAO entity (Extension, Entity, Afform, etc)
After: Works, test added
@civibot
Copy link

civibot bot commented Feb 11, 2022

(Standard links)

@civibot civibot bot added the master label Feb 11, 2022
@eileenmcnaughton eileenmcnaughton merged commit a277a7c into civicrm:master Feb 13, 2022
@eileenmcnaughton eileenmcnaughton deleted the searchKitFixNonDAO branch February 13, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants