BAO_Mailing::create - stop passing by reference #22753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been removing this pass-by-refs on an ongoing basis. CRUD calls should use the api but I checked the core calls and none are looking for anything altered in
|
(Standard links)
|
648bdb1 to
9a17729
Compare
|
@colemanw can you check this? |
colemanw
reviewed
Feb 17, 2022
| @@ -1470,7 +1470,7 @@ public static function add(&$params, $ids = []) { | |||
| * @throws \CRM_Core_Exception | |||
| * @throws \CiviCRM_API3_Exception | |||
| */ | |||
| public static function create(&$params) { | |||
| public static function create(array $params) { | |||
There was a problem hiding this comment.
So this seems to work @eileenmcnaughton but some recent experiences had made me wary of retroactively adding type hints to old functions. It has a tendency to make things blow up and I don't really see the benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
BAO_Mailing::create - stop passing by reference
Before
$paramspassed to BAO_Mailing::create as a referenceAfter
Not a reference
Technical Details
We have been removing this pass-by-refs on an ongoing basis. CRUD calls should use
the api but I checked the core calls and none are looking for anything altered in
I only found one extension in universe using the bao create (unsupported) to create mailings and it does not use params afterwards
Comments