Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for smarty grumpy mode with membership #22752

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fixes for smarty grumpy mode with membership #22752

merged 1 commit into from
Feb 25, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 11, 2022 •
edited
Loading

Overview

Fix escaping, notices in grumpy mode

Before

image

After

image

Technical Details

Generally we bypass escaping for qf html elements in CRM_Core_Smarty
pretty bluntly but these bypass that. Probably ideally we
would actually escape all qf html in the end anyway.

Comments

@civibot
Copy link

civibot bot commented Feb 11, 2022

(Standard links)

@civibot civibot bot added the master label Feb 11, 2022
@eileenmcnaughton
Fixes for smarty grumpy mode with membership
871a867 
Generally we bypass escaping for qf html elements in CRM_Core_Smarty
pretty bluntly but these bypass that. Probably ideally we
would actually escape all qf html in the end anyway.

One notice fix
@eileenmcnaughton
Copy link
Contributor Author

@colemanw can you merge

@colemanw colemanw merged commit f839e1c into civicrm:master Feb 25, 2022
@colemanw colemanw deleted the grumpit branch February 25, 2022 00:26
@colemanw
Copy link
Member

Yep, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw