APIv4 - remove unnecessary field from System::check

[colemanw]

Overview

Following on #22730, this removes the 'severity' field from the System::check api
because it's redundant with 'severity_id:name', and does not appear to be used anywhere.

Before

Redundant field exists. Not used in core. Probably not used outside of core.

After

Removed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@colemanw is it possible it is being used from outside of core?

[colemanw]

@colemanw is it possible it is being used from outside of core?

I seriously doubt it. I know that @MegaphoneJon has an extension which uses this API but I'm pretty sure he's using v3.

[totten]

Core uses severity, but AFAICS it only does APIv3.

ang/crmStatusPage.js:          return crmApi('System', 'check', {sequential: 1, options: {limit: 0, sort: 'severity_id DESC'}});
ang/crmStatusPage/StatusPageCtrl.js:        apiCalls = (apiCalls || []).concat([['System', 'check', {sequential: 1, options: {limit: 0, sort: 'severity_id DESC'}}]]);
ang/crmStatusPage/StatusPageCtrl.js:            ignore_severity: visible ? 0 : status.severity,
ang/crmStatusPage/StatusPageCtrl.js:          return s.is_visible == visibility && s.severity_id >= 2;
ang/crmStatusPage/StatusPage.html:      <h3 class="crm-severity-{{status.severity}}">

I grepped universe for system.*check and found a couple references to the v3 variant but not v4. Some more interested parties might be @agh1 @mlutfy.

I think you're probably right that folks polling for status-checks are more likely to be hitting APIv3... because you'd want some external entry-point, and we've historically had better tooling+docs for v3 access (drush/wp-cli/rest/etc).

Let's wait until Tuesday to see Jon/Andie/Mathieu have any issues with dropping v4's severity field (in favor of severity_id:*). If none, then go ahead and merge.

[MegaphoneJon]

Sorry - I was on vacation last week. No, I don't use this API, I use Andie's Nagios plugin which uses API3 System.check.