Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass grumpy mode for contribution search totals & criteria #22744

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Bypass grumpy mode for contribution totals

These are assigned to the template from php & have nbsp in them (for better or worse)

Also, only escape criteria once

Before

image

After

image

Technical Details

Assuming currencies can't be hacked this assign is secure

Comments

These are assigned to the template from php & have nbsp in them (for better or worse)
@civibot
Copy link

civibot bot commented Feb 10, 2022

(Standard links)

@civibot civibot bot added the master label Feb 10, 2022
@colemanw
Copy link
Member

In general I would say it's definitely "for worse" when a string from php is inserted into the template because it's almost never properly html-escaped. But in this case, ok.

@eileenmcnaughton eileenmcnaughton merged commit d621fad into civicrm:master Feb 10, 2022
@eileenmcnaughton eileenmcnaughton deleted the grump branch February 10, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants