enforce required fields on Contact.duplicatecheck

[MegaphoneJon]

https://lab.civicrm.org/dev/core/-/issues/3065

Overview

Duplicate checking now requires arguments to be passed which previously were optional (at the BAO level).

Before

cv api Contact.duplicatecheck throws a fatal error when you don't pass required values.

After

Exceptions are thrown if you're missing match criteria or a contact type. Rule type is once again optional.

Comments

This is a 5.46 regression; see #22394.

I checked all the other calls to CRM_Contact_BAO_Contact::getDuplicateContacts(). This is the only one that can pass values that don't pass the strict type checking.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Thanks @MegaphoneJon - can you flip to be against the rc?

[MegaphoneJon]

@eileenmcnaughton I'll get it right one day.

[eileenmcnaughton]

Would $params['rule_type'] ?: 'Unsupervised' be more correct?

Also - there IS a default for the field

  $params['rule_type'] = [
    'title' => 'Dedupe Rule Type',
    'description' => 'If no rule id specified, pass "Unsupervised" or "Supervised"',
    'type' => CRM_Utils_Type::T_STRING,
    'api.default' => 'Unsupervised',
  ];

So why isn't that kicking in?

[seamuslee001]

it only seems to kick in when the parameter isn't in the parameters passed to the API call and it seems that at least webform civicrm may be deliberately passing in NULL for this API call https://github.com/civicrm/civicrm-core/blame/master/api/v3/Contact.php#L1608

[seamuslee001]

This seems the right fix to me just flagging as merge ready but I can't think of a reason not to merge this