Format money in custom fields once, on the tpl layer #22728
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Format money in custom fields once, on the tpl layer
Further to #22727 - this attempts to address the double formatting issue
Before
Formatted in the php layer AND the tpl layer
After
Only formatted in the tpl layer
Technical Details
This ensures the raw value is available to the template layer and uses it
rather than the formatted value for money display.
It rather feels it would be better to separate out this view use case in case
there are others hidden in there - but I think this tpl is only
used with this assign
Comments