APIv4 SortableEntity - Fix sorting custom fields with option groups #22716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
jenkins retest this please |
Before: APIv4 would guess which fields to use for grouping when sorting by weight. this caused a bug when sorting custom fields which also had an option_group_id, which was incorrectly guessed to be used for grouping. After: New `@groupWeightsBy` annotation removes the guesswork.
8661249 to
204c3c2
Compare
|
@demeritcowboy this is passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug in the new
APIv4-based sorting which caused custom fields to be incorrectly sorted in the new SearchKit-based Admin UI extension.Before
APIv4 would guess which fields to use for grouping when sorting by weight.
This caused a bug when sorting custom fields which also had an
option_group_id, which was incorrectly guessed to be used for grouping.After
New
@groupWeightsByannotation removes the guesswork, custom fields are sorted correctly.Comments
Once this is merged it will unblock #22628