[REF] Cleanup billingBlock.js #22713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
commented
Feb 5, 2022
| function civicrm_billingblock_creditcard_helper() { | ||
| $(function() { | ||
| $.each(CRM.config.creditCardTypes, function(key, val) { | ||
| var html = '<a href="#" data-card_type=" + key + " title="' + val + '" class="crm-credit_card_type-icon-' + val.css_key + '"><span>' + val.label + '</span></a>'; |
There was a problem hiding this comment.
Note data-card_type was never set correctly due to bad js concatenation here, so it's obviously unused and not needed.
colemanw
commented
Feb 5, 2022
|
|
||
| civicrm_billingblock_creditcard_helper(); |
There was a problem hiding this comment.
This was silly. The function just called another function.
7dc4409 to
8c2b268
Compare
|
This looks much better 👍 |
|
This has been merge ready for a few days merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Code cleanup in
billingBlock.jsBefore
Code messier - unnecessary functions, deprecated variables, malformed html
After
Code neater