Cleanup on contribution view

[eileenmcnaughton]

Overview

This combines #22684 and #22588 and adds a couple of other consistency changes

• Move acl check for contributionView to the extension #22684 is a cleanup that moves acl logic to the financialacls extension
• Generate button links in PHP instead of smarty for ContributionView form #22588 moves button logic from the tpl to the php layer
• In addition this pr makes the payment/submit credit card payment/refund options the same as in the payment details block - it uses the same code to generate the list as the payment block. Understanding the logic for what & where bent my mind & was inconsistent with what we had otherwise settled on. I would also be ok with REMOVING them - since they are elsewhere on the form
• this pr makes the payment summary block always present and abov ethe payment details (it seemed confusing and based on things we've moved away from having them sometimes there)

Before

Pending

Completed

After

Pending

Completed

Technical Details

I feel like the is_template stuff should be a separate form class (which possibly extends or shares a parent with the contribution view for the bits of functionality that are shared) - but it's really the tpl which is going to be really hard to maintain if we don't separate them. That tpl separation can be done even if the template form is overloaded onto the same class

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

Tested and seems to be working. I agree there are probably refinements and we probably don't need the "payment" buttons twice on the same form - but we can refine in future / smaller PRs.

[colemanw]

This PR caused several regressions, documented here: https://lab.civicrm.org/dev/core/-/issues/3168

I think someone testing on Drupal with clean urls wouldn't notice that the urls are getting processed twice, but on other systems it causes the buttons & links to break.