(REF) Queues - Expand docblocks. Extract SQL trait.

[totten]

Overview

A few misc cleanups in CRM/Queue/*.

Before

• Worse docblocks
• More duplicate code (between CRM_Queue_Queue_Sql and CRM_Queue_Queue_SqlParallel)

After

• Better docblocks
• Less duplicate code (with CRM_Queue_Queue_SqlTrait)

Comments

There is pre-existing unit-test coverage for the refactored classes/methods (by way of tests/phpunit/CRM/Queue/). There is even some E2E coverage by way of civicrm-upgrade-test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

@artfulrobot @eileenmcnaughton - This should be a fairly straight-forward (REF).

[artfulrobot]

@totten I've not r-run it, but on a brief visual inspection and with the assumption that the code has just been copy and pasted into the trait, looks good to me and the extra docblock comments are very valuable.

[eileenmcnaughton]

Agree with @artfulrobot

I think it would be good to add type hints to some of these functions - but they are being moved unedited so out of scope