[REF] APIv4 - Deprecate and stop using PreSaveSubscriber #22648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
dc547d8 to
e8562ab
Compare
The PreSaveSubscriber allowed APIs to tweak inputs before saving a record, but it was unreliable because: - It would run for Create and Update but not Save actions - It would run before pseudoconstant suffixes had been resolved - It would run before any formatting or internal processing had taken place Meanwhile, a new pattern of overriding the create/save/update actions and sharing a trait has become more common and while a bit more cumbersome to implement, it does not share those limitations. This removes all uses of PreSaveSubscriber, refactors those bits into Save traits, and adds a deprecation warning in case any extension in the Universe happens to have implemented it.
e8562ab to
ed3f587
Compare
|
Test Coverage should cover us here and this seems fine to me |
|
Should I file a bug report on the above mentioned problem? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactors internal APIv4 code to more reliably handle pre-save processing.
Technical Details
The
PreSaveSubscriberwas added in the early days of APIv4 to tweak inputs before saving a record, but it was unreliable because:CreateandUpdatebut notSaveactionsMeanwhile, a new pattern of overriding the create/save/update actions and sharing a trait has become more common and while a bit more cumbersome to implement, it does not have the above limitations.
This removes all inheritors of
PreSaveSubscriberbut keeps it around with a deprecation warning in case any extension in the Universe happens to rely on it.