Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve inaccuracies in CRM_Core_BAO_File::attachmentInfo docblock #22629

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 26, 2022

Overview

CRM_Core_BAO_File::attachmentInfo returns the result of a implode call which is always a string. Therefore the documented return type of array could not be correct.

Furthermore the commented stated that the number of attachments would be returned, but this is not really true (unless you exploded and counted the result).

Before

Inaccurate comment.

After

More accurate comment.

Comments

I have verified the usage and output of attachmentInfo on the civicrm/activity/view page.

@civibot
Copy link

civibot bot commented Jan 26, 2022

(Standard links)

@civibot civibot bot added the master label Jan 26, 2022
@seamuslee001 seamuslee001 merged commit 6769e8b into civicrm:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants