Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch summary to use the api #22618

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix batch summary to use the api & fix retrieve

Before

Old batch retrieve but when we try to update per #22543 we get a test error - this softens the update - but also avoids the function in the specific test fail
https://test.civicrm.org/job/CiviCRM-Core-PR/46718/testReport/junit/(root)/CRM_Financial_Page_AjaxBatchSummaryTest/testMakeBatchSummary/

After

No change

image

Technical Details

In looking at @colemanw's work to clean up the retrieve function it
turned out that in at least one place NULL is being passed to Batch::retrieve

Since I dug into that 1 place I fixed it to use v4 api (it is
the screen accessed after creating a new accounting batch
from contribution->accounting batches->new batch)

However, it seems safer to continue to accept NULL

Comments

@civibot
Copy link

civibot bot commented Jan 25, 2022

(Standard links)

In looking at @colemanw's work to clean up the retrieve function it
turned out that in at least one place NULL is being passed to Batch::retrieve

Since I dug into that 1 place I fixed it to use v4 api (it is
the screen accessed after creating a new accounting batch
from contribution->accounting batches->new batch)

However, it seems safer to continue to accept NULL
@colemanw colemanw merged commit c4ed61e into civicrm:master Jan 25, 2022
@colemanw colemanw deleted the batch branch January 25, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants