Fix batch summary to use the api #22618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix batch summary to use the api & fix retrieve
Before
Old batch retrieve but when we try to update per #22543 we get a test error - this softens the update - but also avoids the function in the specific test fail
https://test.civicrm.org/job/CiviCRM-Core-PR/46718/testReport/junit/(root)/CRM_Financial_Page_AjaxBatchSummaryTest/testMakeBatchSummary/
After
No change
Technical Details
In looking at @colemanw's work to clean up the retrieve function it
turned out that in at least one place NULL is being passed to Batch::retrieve
Since I dug into that 1 place I fixed it to use v4 api (it is
the screen accessed after creating a new accounting batch
from contribution->accounting batches->new batch)
However, it seems safer to continue to accept NULL
Comments