Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split View Relationship tpl ito own file #22617

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

The inclusion of templates/CRM/Contact/Form/Relationship.tpl simply contains a chunk
of code for the view file in a big IF - this separates that out it's own file & is
more thoughtful about the inclusion....

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

The inclusion of  templates/CRM/Contact/Form/Relationship.tpl simply contains a chunk
of code for the view file in a big IF - this separates that out it's own file & is
more thoughtful about the inclusion....
@civibot
Copy link

civibot bot commented Jan 25, 2022

(Standard links)

@civibot civibot bot added the master label Jan 25, 2022
@yashodha
Copy link
Contributor

@eileenmcnaughton looks good, tested this, works well. I am merging this. Thanks!

@yashodha yashodha merged commit a6a53bb into civicrm:master Jan 25, 2022
@eileenmcnaughton eileenmcnaughton deleted the view branch January 25, 2022 20:19
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants