Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Improve field/operator/value selection UI #22604

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 22, 2022

Overview

Improves the SearchKit UI for selecting field/operator/value conditions. Affects various parts of the UI, like css conditions, link conditions, where/on/having clauses, etc.

Before

  • Inappropriate operators shown for some fields. E.g. "LIKE" for numeric values, <, > or "REGEX" for boolean values are all irrelevant and just clutter the UI.
  • Input widget doesn't always match operator. E.g. a dropdown select shouldn't be paired with the "REGEX" operator.

After

Situation improved.

Technical Details

Carves out yet another component to handle the logic of deciding which operators are appropriate to which fields, and how the input values should be rendered.

Carves out yet another component to handle the logic of deciding which operators are
appropriate to which fields, and how the input values should be rendered.
@civibot
Copy link

civibot bot commented Jan 22, 2022

(Standard links)

@monishdeb
Copy link
Member

Looks good to me, tested with different kinds of fields, and ensured the right set of operators are loaded.

@monishdeb monishdeb merged commit b63971f into civicrm:master Jan 24, 2022
@colemanw colemanw deleted the searchKitOperators branch January 24, 2022 13:17
@colemanw
Copy link
Member Author

Thanks @monishdeb

@eileenmcnaughton
Copy link
Contributor

thanks @colemanw

colemanw added a commit to colemanw/civicrm-core that referenced this pull request Jan 28, 2022
Fixes dev/core#3046 which was caused by incomplete refactoring in
civicrm#22604
colemanw added a commit to colemanw/civicrm-core that referenced this pull request Jan 28, 2022
Fixes dev/core#3046 which was caused by incomplete refactoring in
civicrm#22604
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants