Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless function #22585

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Remove useless function #22585

merged 1 commit into from
Jan 21, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 20, 2022

Overview

Removes unnecessary function which does nothing except call another function and is only used once.

Before

Unused

After

Gone

@civibot
Copy link

civibot bot commented Jan 20, 2022

(Standard links)

@civibot civibot bot added the master label Jan 20, 2022
@demeritcowboy
Copy link
Contributor

Could we just get rid of this function? It's only used one place in universe and it doesn't do what you would expect from a function called isDate() - I'd assume it checks if it's a valid date, but that's not what it does.

@colemanw colemanw changed the title Remove unused pass-by-ref Remove useless function Jan 20, 2022
@colemanw
Copy link
Member Author

@demeritcowboy good call!

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton eileenmcnaughton merged commit b8f45de into civicrm:master Jan 21, 2022
@eileenmcnaughton eileenmcnaughton deleted the pissbyref branch January 21, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants