Remove duplicate file #22569
Merged
Remove duplicate file #22569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
GetTargetandAssignee.ex.php should be removed, the other one is created from the test tests//phpunit/api/v3/ActivityTest.php:382 |
|
Ok thanks. It's strange that there's another file GetTargetandAssigneeName.ex.php which only has a small "a". But I'll update since I see now it goes by what's in |
|
@demeritcowboy please merge this once you are happy with it |
94615e2 to
7f01007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Something weird happened at #22531
It added a whole new file instead of updating the existing one, due to mismatched case in the filename. I don't know which is the right one of GetTargetAndAssignee.ex.php and GetTargetandAssignee.ex.php so I'm just picking one to delete.
https://github.com/civicrm/civicrm-core/tree/cf2f87fbef5139c29a81e126d449d2d084066d55/api/v3/examples/Activity
On windows it thinks I've modified the file locally since it thinks those files are the same file.